aminghadersohi commented on code in PR #40435:
URL: https://github.com/apache/superset/pull/40435#discussion_r3343415171
##########
superset/translations/messages.pot:
##########
@@ -5497,6 +5500,9 @@ msgstr ""
msgid "FIT DATA"
Review Comment:
**BLOCKER (CI)**: Same orphaned-msgid issue as `COPY QUERY` above. `FIT
DATA` is no longer in any source file after this PR, but it remains in
`messages.pot`. Remove this entry along with its corresponding stale entries in
all locale `.po` files.
##########
superset/translations/messages.pot:
##########
@@ -2155,6 +2155,9 @@ msgstr ""
msgid "COPY QUERY"
Review Comment:
**BLOCKER (CI)**: This entry is now orphaned — `COPY QUERY` no longer
appears anywhere in the source after this PR's change to `Copy query`. The
`babel-extract` CI check re-runs `pybabel extract` and diffs the result; since
this msgid is gone from source, the regenerated `.pot` omits it, creating a
diff that fails the check.
Remove this entry (and the `FIT DATA` entry below) from `messages.pot`, and
mark/remove the corresponding old entries from all locale `.po` files. The
cleanest fix: re-run `pybabel extract ... -o
superset/translations/messages.pot` then `pybabel update -i
superset/translations/messages.pot -d superset/translations` — babel will
automatically prune the orphaned entries.
##########
superset-frontend/package.json:
##########
@@ -352,7 +352,7 @@
"lightningcss": "^1.32.0",
"mini-css-extract-plugin": "^2.10.2",
"open-cli": "^9.0.0",
- "oxlint": "^1.66.0",
+ "oxlint": "^1.67.0",
Review Comment:
NIT: oxlint version bump (1.66.0 → 1.67.0) is unrelated to the sentence-case
fix — consider putting it in a separate PR to keep the diff minimal.
##########
superset-frontend/src/components/Chart/chartAction.ts:
##########
@@ -817,8 +817,9 @@ export function exploreJSON(
),
);
(queriesResponse as QueryData[]).forEach(response => {
- if (response.warning) {
- dispatch(addWarningToast(response.warning, { noDuplicate: true }));
+ const { warning } = response as { warning?: string | null };
Review Comment:
**MEDIUM**: This cast is a workaround for `warning` not being in the
`QueryData` type definition. Consider adding `warning?: string | null;` to
`QueryData` in `superset-frontend/src/query/types/QueryResponse.ts` and
removing this cast — that fixes the root cause rather than suppressing the type
error.
##########
superset/translations/ar/LC_MESSAGES/messages.po:
##########
@@ -34,7 +34,7 @@ msgstr ""
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
-"Generated-By: Babel 2.15.0\n"
+"Generated-By: Babel 2.18.0\n"
Review Comment:
**BLOCKER (CI)**: All `.po` files have their header bumped from
`Generated-By: Babel 2.15.0` to `Generated-By: Babel 2.18.0`, meaning these
were regenerated with a newer Babel than what the project currently pins. The
`check-python-deps` CI runs `./scripts/uv-pip-compile.sh` when Python-adjacent
files change and then checks for uncommitted diffs — if the pinned Babel
version in `requirements/` doesn't reflect 2.18.0, the recompile produces a
diff and the check fails.
Fix: run `./scripts/uv-pip-compile.sh` from the repo root and commit any
changes to `requirements/*.txt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
