sadpandajoe commented on PR #40000:
URL: https://github.com/apache/superset/pull/40000#issuecomment-4605674173
Can we add tests that mirrors the tests in
`src/filters/components/TimeGrain/TimeGrainPreFilter.integration.test.tsx`
which has 2 cases (~165 lines). Same render + userEvent.click(combobox) +
getAllByRole('option') shape, but import the customization plugin instead of
the native one, and add a third case for the escape hatch since that's the new
behavior this PR introduces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]