Copilot commented on code in PR #40696:
URL: https://github.com/apache/superset/pull/40696#discussion_r3345750123
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx:
##########
@@ -800,6 +800,73 @@ test('does not auto-create a filter when createNewOnOpen
is false', () => {
expect(screen.queryByText(DATASET_REGEX)).not.toBeInTheDocument();
});
+test('enables save button and includes updated title when editing an existing
divider', async () => {
+ jest.useFakeTimers();
+
+ const nativeFilterDividerConfig = [
+ {
Review Comment:
This test only covers the NATIVE_FILTER_DIVIDER-* path, but the production
change also includes CHART_CUSTOMIZATION_DIVIDER-* via isDivider(). To prevent
regressions and fully cover the stated behavior, add a companion test case that
seeds dashboardInfo.metadata.chart_customization_config with a
CHART_CUSTOMIZATION_DIVIDER-* item and asserts that editing its Title enables
Save and that the saved payload includes the updated title for that divider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
