bito-code-review[bot] commented on PR #40697: URL: https://github.com/apache/superset/pull/40697#issuecomment-4609002223
<!-- Bito Reply --> The flagged issue is correct. The `titleLabel` field is currently persisted without trimming, allowing whitespace-only strings to be treated as valid labels, which causes them to render as empty-looking filter names in dynamic titles. To resolve this, you should trim the `titleLabel` value and set it to `undefined` if the resulting string is empty. Here is the suggested fix for `superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/transformers/filterTransformer.ts`: ```typescript // Replace the existing titleLabel assignment with this logic: titleLabel: formInputs.titleLabel?.trim() || undefined, ``` I have checked the PR comments, and there are no other actionable suggestions currently listed in the review. Would you like me to perform a deeper analysis of the PR to see if there are other areas that might need attention? **superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/transformers/filterTransformer.ts** ``` titleLabel: formInputs.titleLabel?.trim() || undefined, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
