villebro commented on issue #8183: How to pass time filters to SQL Lab queries URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-533304850 Can you post a case where a jinja-based date filter needs to be used? I'm not saying there isn't one, but as the majority of modern engines are able to do predicate pushdown into the subquery, the need for injecting date filters should be very uncommon. If I understood your example correctly, the original query ```sql SELECT * FROM table ``` should turn into ```sql SELECT cols FROM (SELECT * FROM table) AS expr_qry WHERE <time filters> ``` when a filter box emits a time filter, i.e. the time filter will be appended to the query without the need for jinja trickery.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
