bito-code-review[bot] commented on PR #40712:
URL: https://github.com/apache/superset/pull/40712#issuecomment-4614911269
<!-- Bito Reply -->
The reviewer's suggestion to explicitly assert the absence of `guest_token`
in the form body when `getGuestToken()` returns `undefined` is a valid
improvement. Adding an assertion like
`expect(request.body.get('guest_token')).toBeNull()` in the test suite provides
a clear boundary and prevents potential regressions where a token might be
accidentally injected in future refactors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]