bito-code-review[bot] commented on code in PR #40220:
URL: https://github.com/apache/superset/pull/40220#discussion_r3350493451
##########
superset-frontend/src/chartCustomizations/components/DynamicGroupBy/types.ts:
##########
@@ -76,7 +76,6 @@ export const DEFAULT_FORM_DATA:
PluginFilterGroupByCustomizeProps = {
dataset: null,
column: null,
sortFilter: false,
- sortAscending: true,
canSelectMultiple: true,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Default sort behavior changed</b></div>
<div id="fix">
Removing `sortAscending: true` from DEFAULT_FORM_DATA changes the default
dropdown behavior from A-Z sorting to preserving source order (line 46:
`sortAscending?: boolean`). Code at lines 123-124 shows `undefined` disables
sorting. Confirm this is intentional—if not, add back the default.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
---
superset-frontend/src/chartCustomizations/components/DynamicGroupBy/types.ts
+++
superset-frontend/src/chartCustomizations/components/DynamicGroupBy/types.ts
@@ -76,6 +76,7 @@ export const DEFAULT_FORM_DATA:
PluginFilterGroupByCustomizeProps = {
dataset: null,
column: null,
sortFilter: false,
+ sortAscending: true,
canSelectMultiple: true,
defaultValue: null,
};
```
</div>
</details>
</div>
<small><i>Code Review Run #dc1239</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
