sadpandajoe commented on PR #40720: URL: https://github.com/apache/superset/pull/40720#issuecomment-4614995157
@hainenber why would not run e2e until post merge. The question is post-merge, say it fails e2e, who is reverting or responsible for fixing this? I think this will cause a lot more issues instead of just doing the e2e tests now. A good compromise would be to not run e2e in draft and make that the manual run step, that way you can still run all your tests in draft and only pull it out when you are ready for an actual review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
