rusackas commented on PR #40717: URL: https://github.com/apache/superset/pull/40717#issuecomment-4615626986
Thanks @sadpandajoe — dug into this and nothing's being dropped, but the numbers are illuminating. **There are only 5 Cypress spec files / 31 test cases left in the repo** (the rest migrated to Playwright + RTL — e.g. #39071, #38924, #38368, #35938). `scripts/cypress_run.py` distributes them round-robin across shards and runs every group, so the union always equals the full set — no specs are skipped. On master today the matrix is 6 shards × 2 app_roots = **12 Cypress jobs**, and with only 5 specs the round-robin leaves a shard empty — so **a couple of those 12 jobs spin up the full env (Python + Postgres + Node + asset build, ~8–10 min) and run zero specs**, and the rest run ~1 spec each. The whole E2E workflow burns **~143 runner-minutes to execute 31 short tests** — almost entirely setup overhead. Per your "more tests per shard" point — exactly. I've cut this to **2 shards** (`PARALLELISM: 2`): on PRs that's 2 Cypress jobs (3 + 2 specs), on push 2 + 1 smoke `/app/prefix`. Coverage identical, far less duplicated setup. > reduce the number of shards for playwright. I think currently playwright only runs on 1 shard Good eye — though Playwright isn't sharded by `parallel_id` here at all; `playwright-tests` runs the full *required* suite once per app_root (the ~13–16 min job). Since Playwright now carries the bulk of E2E, it's the candidate for *adding* parallelism (its native `--shard`) if we want it faster — the opposite direction from Cypress. **Bigger picture:** with only 5 specs left, it's probably worth finishing their migration to Playwright and retiring the Cypress job entirely. Out of scope here, but flagging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
