rusackas commented on PR #40722: URL: https://github.com/apache/superset/pull/40722#issuecomment-4615728012
Fair question, and it's the main tradeoff here. Two parts: **Scope:** only failures that pass on 3.11 (current — still runs on every PR) but break *specifically* on 3.10 or 3.12 would slip past PR CI. Anything version-agnostic is still caught pre-merge. So it's not "no Python tests on PRs," it's "only the extra two versions move to push/nightly." **Ownership:** you're right that a version-specific break would land on master and need fixing post-merge (attributable to the merging commit; nightly + push surface it within a day). That's the same model as the existing push-only matrix jobs (e.g. the docker `py310/py311/py312` presets), but it is real post-merge exposure. To shrink that risk to near-zero, I can keep **current + previous** (3.11 + 3.10 — the two shipped runtimes) on PRs and defer only **`next`/3.12** (the forward-looking canary) to push + nightly. That keeps real prod-version breakage gated pre-merge and only lets the experimental version surface post-merge — which is what it's there to do. Slightly less savings, much smaller blast radius. Happy to make that change if you prefer it — or to add a master-CI-failure notification so nothing sits silently red. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
