dfgvaetyj3456356-hash commented on PR #40498: URL: https://github.com/apache/superset/pull/40498#issuecomment-4619540673
Added a focused coverage follow-up in 606f32a for the invalid Google Sheets URL validation path. The new test drives validate_parameters() with a malicious catalog URL and asserts the SQL query path is not reached. Local validation: - python -m py_compile superset\db_engine_specs\gsheets.py tests\unit_tests\db_engine_specs\test_gsheets.py - python -m ruff format tests\unit_tests\db_engine_specs\test_gsheets.py --check - python -m ruff check superset\db_engine_specs\gsheets.py tests\unit_tests\db_engine_specs\test_gsheets.py - git diff --check origin/master...HEAD The targeted pytest command is still blocked in my local checkout by the missing optional flask_appbuilder dependency during conftest import, so I am relying on upstream CI for the full test run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
