aminghadersohi commented on code in PR #40472:
URL: https://github.com/apache/superset/pull/40472#discussion_r3357215486
##########
superset-frontend/src/pages/ChartCreation/index.tsx:
##########
@@ -353,6 +353,7 @@ export class ChartCreation extends PureComponent<
optionFilterProps={['id', 'table_name']}
placeholder={t('Choose a %s', datasetLabelLower())}
showSearch
+ oneLine
Review Comment:
This select has no `mode` prop, so it defaults to `'single'`. The `oneLine`
prop is designed for multi-select — it controls tag-overflow rendering when
multiple items are selected. In single mode its only real effect is changing
`popupMatchSelectWidth` from the default `true` to a JS-measured pixel width,
which is functionally equivalent here.
Also, this component is on the Chart Creation page and isn't mentioned in
the PR description or linked issue #40430, which is scoped to the role form
permissions dropdown. If there's a separate width issue here it should be a
separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
