bito-code-review[bot] commented on PR #40758:
URL: https://github.com/apache/superset/pull/40758#issuecomment-4623947653
<!-- Bito Reply -->
To migrate away from the legacy `describe` block structure, you can move the
tests into a top-level `describe` block or a separate test file. Given the
context of the existing file, you can refactor the new tests into their own
`describe` block at the top level of the test suite, outside of the legacy
`dashboardState actions` block.
Here is how you can structure the refactored tests:
```typescript
describe('dashboardState actions - certification fields', () => {
test('clears certification_details when certified_by is cleared', async ()
=> {
// ... test implementation
});
test('preserves certification_details when certified_by is set', async ()
=> {
// ... test implementation
});
test('omits certification fields when certified_by is undefined', async ()
=> {
// ... test implementation
});
});
```
**superset-frontend/src/dashboard/actions/dashboardState.test.ts**
```
describe('dashboardState actions - certification fields', () => {
test('clears certification_details when certified_by is cleared', async ()
=> {
// ... test implementation
});
test('preserves certification_details when certified_by is set', async ()
=> {
// ... test implementation
});
test('omits certification fields when certified_by is undefined', async ()
=> {
// ... test implementation
});
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
