rusackas opened a new pull request, #40772:
URL: https://github.com/apache/superset/pull/40772
### SUMMARY
Follow-up to #40770. Frontend-only PRs (e.g. Dependabot npm bumps like
#40757)
are still blocked from merging — stuck on **`unit-tests (current)`** and
**`test-postgres (current)`** showing *"Expected — Waiting for status to be
reported."*
**Root cause:** #40718 moved `unit-tests` and `test-postgres` to
**job-level**
change-detection gating (`if: needs.changes.outputs.python == 'true'`). On a
non-Python PR the job is skipped — and a job-level skip happens **before
matrix
expansion**, so the per-combination contexts `unit-tests (current)` /
`test-postgres (current)` are **never created**. Branch protection requires
them, so the PR waits forever.
This only bites *matrix* jobs. Non-matrix gated jobs (`test-mysql`,
`test-sqlite`) publish a `skipped` check that branch protection treats as
success — which is why only the two matrix contexts were stuck.
**Fix:** add an always-running `*-required` anchor job for each matrix job
that
passes when the underlying job is `success` **or** `skipped`, and fails only
on
a real failure. Point the required status checks at those anchors:
```yaml
unit-tests-required:
needs: [changes, unit-tests]
if: always()
steps:
- run: |
[ "$RESULT" = success ] || [ "$RESULT" = skipped ] || exit 1
env: { RESULT: "${{ needs.unit-tests.result }}" }
```
`.asf.yaml`: `unit-tests (current)` → `unit-tests-required`, `test-postgres
(current)` → `test-postgres-required`. The expensive matrix jobs stay **fully
skipped** on unrelated PRs (no wasted Postgres/Redis service containers); the
anchor is a ~5-second no-op.
> 📝 Related follow-up: #40722 (Python matrix → current-only on PRs) will stop
> producing `pre-commit (previous)` on PRs. That's a *matrix reduction*, not
a
> job-skip, so it just needs the `pre-commit (previous)` context removed from
> `.asf.yaml` — handled in that PR, no shim required.
### TESTING INSTRUCTIONS
- Python PR: `unit-tests-required` / `test-postgres-required` run after the
matrix jobs and pass.
- Frontend-only / docs PR: the matrix jobs skip; the anchors run and pass;
the
PR is mergeable.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
