aminghadersohi commented on code in PR #38107:
URL: https://github.com/apache/superset/pull/38107#discussion_r3357516739
##########
superset-frontend/src/features/databases/DatabaseModal/index.test.tsx:
##########
@@ -2134,6 +2134,42 @@ describe('dbReducer', () => {
});
});
+ // Regression test for https://github.com/apache/superset/issues/30504
+ // When creating a database, the POST response doesn't include
engine_information,
+ // but it should be preserved from the initial state set by DbSelected
action.
Review Comment:
NIT: the comment names `DbSelected` by its `ActionType` enum key. If the
action is ever renamed, this comment will drift. Consider describing the effect
rather than the action — e.g. *"…preserved from the state populated when the
user selects a database engine."* Test logic is correct regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
