Vitor-Avila opened a new pull request, #40774: URL: https://github.com/apache/superset/pull/40774
### SUMMARY When saving/updating a chart, it's possible to also add it to a dashboard. When the chart is added to a dashboard this way, it's not formally added to the dashboard's `position_json`. This PR fixes the logic in `_is_filter_in_scope_for_chart` to also consider charts in this scenario. This fix is needed for: * MCP interactions * API calls to `/api/v1/chart/data` with the `filters_dashboard_id` URL param. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. ### TESTING INSTRUCTIONS Unit tests added. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
