EnxDev commented on PR #40443:
URL: https://github.com/apache/superset/pull/40443#issuecomment-4625623634

   > CC @villebro @michael-s-molina
   > 
   > I might have missed the memo on the extension settings API? How does that 
overlap/intersect with the [Extension Storage 
PR](https://github.com/apache/superset/pull/39171) from @michael-s-molina 
and/or the User Preferences SIP (from @ville)?
   
   Good question — they're complementary, different scopes:
   
   This PR (extension settings) stores admin-global, deployment-wide state: 
which extensions are installed/available (enabled map) and the active chatbot 
(active_chatbot_id). One row, no user_fk, admin-only writes.
   @michael-s-molina's Extension Storage PR (#39171) stores per-user (and 
shared/resource-scoped) extension data — the place an extension persists what a 
given user wants.
   User Preferences [SIP-127](https://github.com/apache/superset/issues/28047) 
is the same per-user pattern for core Superset settings (theme, timezone, 
locale).
   So there's no functional overlap today — admin "is this available?" vs user 
"what do I want?" are different layers. 
   The intersection worth flagging is per-user extension enablement: today 
enabled is global, so an extension that's useful to one user but useless to 
another can only be toggled deployment-wide. 
   That per-user override belongs on top of the Extension Storage PR (per-user 
scope), not as a second table here; this PR stays the admin-availability layer.
   
   One small follow-up I'd suggest: rename/document enabled as 
"installed/available" so it doesn't read as a personal toggle once per-user 
preferences land.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to