rusackas commented on PR #39459: URL: https://github.com/apache/superset/pull/39459#issuecomment-4626855085
Thanks @aminghadersohi! Addressed all three in 0e0685232a: - **MEDIUM (FilterState shadowing)** — Removed the local `FilterState` interface in `ChartRenderer.tsx` and imported the canonical one from `@superset-ui/core`, so it can't drift from the version `Chart.tsx` already uses. - **NIT (unused `setDataMask`)** — Dropped the prop from `ChartRendererProps`. It was dead even in the pre-refactor class version (the hook always routed through `actions.updateDataMask`), so there's no call site to wire up. - **NIT (tautological matrixify test)** — Rewrote `should detect changes in matrixify properties` to assert on the rendered `SuperChart` output (matching its sibling tests) instead of re-checking its own fixture values. CI green locally (type-check + the full `ChartRenderer.test.tsx` suite pass). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
