FullStackChef opened a new pull request, #40784:
URL: https://github.com/apache/superset/pull/40784
### SUMMARY
Fixes #40783.
The deck.gl chart legend rendered each category colour swatch as the Unicode
glyph `◼` (U+25FC) / `◻` (U+25FB) tinted only via the CSS `color` property.
Those code points are in Unicode's Emoji set but lack `Emoji_Presentation`,
so
Chromium-based browsers (Chrome/Edge/Chromium) resolve them to a colour-emoji
font (Noto Color Emoji / Segoe UI Emoji / Apple Color Emoji). Emoji glyphs
carry baked-in colour and **ignore CSS `color`**, so the swatch renders as a
**black square** regardless of the category colour. Firefox uses a monochrome
text glyph that honours `color`, which is why it was unaffected. (Full
diagnosis by @alex-poor in #40783.)
This replaces the colour-tinted glyph with a real bordered `<span>` box whose
`background-color` is the category colour — filled when the category is
enabled, hollow (border only) when disabled. A box renders nothing through
the
font layer, so it is immune to emoji-font presentation and always reflects
the
category colour. Interactions (toggle / double-click) are unchanged.
The component is shared by the **Polygon, Scatterplot, Arc and Path** deck.gl
charts, so all four are fixed by this change.
It also removes a stray leftover `className="dupa"` on the legend container
(introduced inadvertently in the #24933 TS conversion; no CSS targets it).
### BEFORE/AFTER
**Before (Chromium):** a black square for every category — see the
screenshots
in #40783.
**After:** each swatch shows its category colour, matching Firefox and the
map
fill. _(After-screenshot to be added.)_
### TESTING INSTRUCTIONS
1. In a Chromium-based browser (Chrome/Edge) on a machine with a colour-emoji
font installed (default on Windows/macOS/most Linux desktops).
2. Open a deck.gl Polygon (or Scatterplot / Arc / Path) chart configured
with a
categorical colour so the legend shows category swatches.
3. The swatch to the left of each category label should now match the
category
colour. Previously it was a black square.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #40783
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime checks performed on DB migrations
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
