rusackas commented on code in PR #40780:
URL: https://github.com/apache/superset/pull/40780#discussion_r3360267589
##########
.github/workflows/superset-e2e.yml:
##########
@@ -277,3 +277,46 @@ jobs:
${{ github.workspace }}/superset-frontend/playwright-results/
${{ github.workspace }}/superset-frontend/test-results/
name: playwright-artifact-${{ github.run_id }}-${{ github.job }}-${{
matrix.browser }}--${{ steps.set-safe-app-root.outputs.safe_app_root }}
+
+ # Stable required-status-check anchors. cypress-matrix and playwright-tests
+ # are matrix jobs gated on change detection (python || frontend). On a PR
+ # that touches neither — e.g. a docs-only PR — they are skipped at the job
+ # level, which happens before matrix expansion, so the per-combination
+ # contexts (`cypress-matrix (0, chrome)`, `playwright-tests (chromium)`) are
+ # never produced and branch protection waits on them forever. These
+ # always-running jobs report a single stable context that passes when the
+ # underlying matrix job succeeded or was skipped, and fails only on a real
+ # failure. Require these in .asf.yaml instead of the matrix-expanded names.
+ cypress-matrix-required:
+ needs: [changes, cypress-matrix]
+ if: always()
+ runs-on: ubuntu-24.04
+ timeout-minutes: 5
+ permissions: {}
+ steps:
+ - name: Check cypress-matrix result
+ env:
+ RESULT: ${{ needs.cypress-matrix.result }}
+ run: |
+ if [ "$RESULT" != "success" ] && [ "$RESULT" != "skipped" ]; then
Review Comment:
Good catch — that's a real hole. You're right: GHA marks a job `skipped`
both when its `if:` gates it off *and* when a `needs` dependency (here
`changes`) fails or is cancelled, so the unconditional `skipped` accept could
green a run where change detection actually broke.
Fixed in 67c316a24d: each anchor now requires `needs.changes.result ==
'success'` before honouring a skip. So:
- `changes` succeeds + matrix skipped (docs-only gate-off) → pass ✅
- `changes` succeeds + matrix success → pass ✅
- matrix failed → fail ❌
- `changes` failed/cancelled (matrix skipped as a side effect) → fail ❌ (no
more false green)
##########
.github/workflows/superset-e2e.yml:
##########
@@ -277,3 +277,46 @@ jobs:
${{ github.workspace }}/superset-frontend/playwright-results/
${{ github.workspace }}/superset-frontend/test-results/
name: playwright-artifact-${{ github.run_id }}-${{ github.job }}-${{
matrix.browser }}--${{ steps.set-safe-app-root.outputs.safe_app_root }}
+
+ # Stable required-status-check anchors. cypress-matrix and playwright-tests
+ # are matrix jobs gated on change detection (python || frontend). On a PR
+ # that touches neither — e.g. a docs-only PR — they are skipped at the job
+ # level, which happens before matrix expansion, so the per-combination
+ # contexts (`cypress-matrix (0, chrome)`, `playwright-tests (chromium)`) are
+ # never produced and branch protection waits on them forever. These
+ # always-running jobs report a single stable context that passes when the
+ # underlying matrix job succeeded or was skipped, and fails only on a real
+ # failure. Require these in .asf.yaml instead of the matrix-expanded names.
+ cypress-matrix-required:
+ needs: [changes, cypress-matrix]
+ if: always()
+ runs-on: ubuntu-24.04
+ timeout-minutes: 5
+ permissions: {}
+ steps:
+ - name: Check cypress-matrix result
+ env:
+ RESULT: ${{ needs.cypress-matrix.result }}
+ run: |
+ if [ "$RESULT" != "success" ] && [ "$RESULT" != "skipped" ]; then
+ echo "cypress-matrix did not pass (result: $RESULT)"
+ exit 1
+ fi
+ echo "cypress-matrix result: $RESULT"
+
+ playwright-tests-required:
+ needs: [changes, playwright-tests]
+ if: always()
+ runs-on: ubuntu-24.04
+ timeout-minutes: 5
+ permissions: {}
+ steps:
+ - name: Check playwright-tests result
+ env:
+ RESULT: ${{ needs.playwright-tests.result }}
+ run: |
+ if [ "$RESULT" != "success" ] && [ "$RESULT" != "skipped" ]; then
Review Comment:
Addressed together with the cypress anchor in 67c316a24d —
`playwright-tests-required` now applies the same `needs.changes.result ==
'success'` guard before accepting a skip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
