Bungic commented on PR #40801: URL: https://github.com/apache/superset/pull/40801#issuecomment-4631295523
CSV_EXPORT is defined unconditionally in superset/config.py and direct subscript is the existing pattern everywhere else it is read (charts/data/api.py, viz.py, commands/sql_lab/export.py), so a missing key is not a reachable state in a Superset app and I would rather stay consistent with that. What I did take from the review: the config read now happens only inside the str branch (7cb5d14), so byte payloads pass through without touching config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
