bito-code-review[bot] commented on code in PR #39330: URL: https://github.com/apache/superset/pull/39330#discussion_r3362862555
########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -16330,6 +16359,10 @@ msgstr "" msgid "Whether to display the min and max values of the Y-axis" msgstr "" +#, fuzzy +msgid "Whether to display the numbered column" +msgstr "Seleziona una metrica da visualizzare" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect fuzzy translation</b></div> <div id="fix"> Fuzzy entry has incorrect translation. 'Seleziona una metrica da visualizzare' (Select a metric to display) does not match 'Whether to display the numbered column'. Either provide correct translation or clear the msgstr. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -1160,6 +1160,10 @@ msgstr "" msgid "Add new formatter" msgstr "" +#, fuzzy +msgid "Add numbered column" +msgstr "Visualizza colonne" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect fuzzy translation</b></div> <div id="fix"> The translation 'Visualizza colonne' (Show columns) is incorrectly applied to 'Add numbered column'. This fuzzy translation was likely copy-pasted and does not convey the intended meaning. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -17895,6 +17928,10 @@ msgstr "Importa" msgid "value descending" msgstr "Importa" +#, fuzzy +msgid "valuename" +msgstr "Database" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect fuzzy translation</b></div> <div id="fix"> Fuzzy entry has incorrect translation. 'Database' does not match 'valuename'. Either provide correct translation or clear the msgstr. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -4371,6 +4375,13 @@ msgstr "" "As métricas ad-hoc de SQL personalizado não estão ativadas para este " "conjunto de dados" +msgid "Custom SQL fields cannot be parsed as a single SQL statement." +msgstr "" + +#, fuzzy +msgid "Custom SQL fields cannot contain set operations." +msgstr "Os campos SQL personalizados não podem conter subconsultas." Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation mismatch with msgid</b></div> <div id="fix"> Fuzzy entry 'Custom SQL fields cannot contain set operations.' has translation about sub-queries instead of set operations. The msgid and msgstr describe different errors. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -9625,7 +9636,7 @@ msgstr "" msgid "No table columns" msgstr "Nenhuma coluna da tabela" -#, fuzzy, python-format +#, fuzzy msgid "No tasks yet" msgstr "Sem %s ainda" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Placeholder mismatch in translation</b></div> <div id="fix"> Fuzzy entry 'No tasks yet' has %s placeholder in translation but msgid has no placeholder. This will cause formatting issues at runtime. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -4371,6 +4375,13 @@ msgstr "" "As métricas ad-hoc de SQL personalizado não estão ativadas para este " "conjunto de dados" +msgid "Custom SQL fields cannot be parsed as a single SQL statement." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Untranslated new string</b></div> <div id="fix"> New entry 'Custom SQL fields cannot be parsed as a single SQL statement.' has empty msgstr, causing English text to display to Portuguese users. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -1275,6 +1275,10 @@ msgstr "Adicionar novo formatador de cores" msgid "Add new formatter" msgstr "Adicionar novo formatador" +#, fuzzy +msgid "Add numbered column" +msgstr " para adicionar colunas calculadas" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incomplete translation entry</b></div> <div id="fix"> The new entry 'Add numbered column' has an empty/incomplete translation (' para adicionar colunas calculadas') with a fuzzy flag. This will display incorrectly to users. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -1930,7 +1934,7 @@ msgstr "Ocorreu um erro ao analisar a chave." msgid "An error occurred while pruning logs " msgstr "Ocorreu um erro ao podar os registos" -#, fuzzy, python-format +#, fuzzy msgid "An error occurred while refreshing the configuration schema" msgstr "Ocorreu um erro ao renderizar a visualização: %s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Placeholder mismatch in translation</b></div> <div id="fix"> Fuzzy entry has %s placeholder in translation but msgid has no placeholder. This will cause formatting issues at runtime. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -10805,6 +10820,12 @@ msgstr "Depreciado" msgid "Proportional" msgstr "Proporcional" +msgid "Public and privately shared sheets" +msgstr "" + +msgid "Publicly shared sheets only" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Untranslated new strings</b></div> <div id="fix"> Two new entries for sheet sharing options have empty msgstr values, causing English text to display to Portuguese users. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -1853,7 +1857,7 @@ msgstr "Ocorreu um erro durante a extração dos valores do esquema: %s" msgid "An error occurred while fetching semantic layer types" msgstr "Ocorreu um erro ao buscar os modelos CSS disponíveis" -#, fuzzy, python-format +#, fuzzy msgid "An error occurred while fetching semantic layers" msgstr "Ocorreu um erro durante a extração dos valores do esquema: %s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Placeholder mismatch in translation</b></div> <div id="fix"> Fuzzy entry has %s placeholder in translation but msgid has no placeholder. This will cause formatting issues at runtime. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -16118,6 +16145,12 @@ msgstr "Desfazer a ação" msgid "Undo?" msgstr "Desfazer?" +#, fuzzy +msgid "Unexpected HTTP 401 response. Check your credentials." +msgstr "" +"Ocorreu um erro inesperado, verifique os registros(logs) para obter " +"detalhes" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-20: Wrong fuzzy translation</b></div> <div id="fix"> The fuzzy translation at line 16151-16152 says 'Ocorreu um erro inesperado' (unexpected error), but the msgid describes an HTTP 401 authentication error specifically. Portuguese users will see a misleading error message that doesn't match the actual condition. (See also: [CWE-20](https://cwe.mitre.org/data/definitions/20.html)) </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/pt_BR/LC_MESSAGES/messages.po +++ b/superset/translations/pt_BR/LC_MESSAGES/messages.po @@ -16145,10 +16145,9 @@ msgstr "Desfazer?" #, fuzzy msgid "Unexpected HTTP 401 response. Check your credentials." -msgstr "" -"Ocorreu um erro inesperado, verifique os registros(logs) para obter " -"detalhes" +msgstr "Resposta HTTP 401 inesperada. Verifique suas credenciais." ``` </div> </details> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -15954,6 +15978,9 @@ msgstr "Digite um valor" msgid "Type is required" msgstr "O tipo é obrigatório" +msgid "Type of Google Sheets allowed" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Portuguese translation</b></div> <div id="fix"> The new msgid 'Type of Google Sheets allowed' at line 15981 has an empty msgstr. This user-facing text will display untranslated in the Portuguese UI. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/pt_BR/LC_MESSAGES/messages.po +++ b/superset/translations/pt_BR/LC_MESSAGES/messages.po @@ -15978,6 +15978,7 @@ msgstr "O tipo é obrigatório" msgid "Type of Google Sheets allowed" -msgstr "" +msgstr "Tipo de Google Sheets permitido" ``` </div> </details> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -18713,6 +18750,10 @@ msgstr "valor crescente" msgid "value descending" msgstr "valor decrescente" +#, fuzzy +msgid "valuename" +msgstr "Nome da Tabela" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-20: Mismatched fuzzy translation</b></div> <div id="fix"> The fuzzy translation at line 18755 says 'Nome da Tabela' (Table Name), but the msgid is 'valuename' which likely refers to a value name or field name in a data context. This mismatch will confuse users configuring data mappings. (See also: [CWE-20](https://cwe.mitre.org/data/definitions/20.html)) </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/pt_BR/LC_MESSAGES/messages.po +++ b/superset/translations/pt_BR/LC_MESSAGES/messages.po @@ -18750,7 +18750,7 @@ msgstr "valor decrescente" #, fuzzy msgid "valuename" -msgstr "Nome da Tabela" +msgstr "Nome do valor" ``` </div> </details> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -17106,6 +17139,10 @@ msgstr "Se devem ser exibidos os valores mínimo e máximo do eixo X" msgid "Whether to display the min and max values of the Y-axis" msgstr "Se devem ser exibidos os valores mínimo e máximo do eixo Y" +#, fuzzy +msgid "Whether to display the numbered column" +msgstr "Se a linha de tendência deve ser exibida" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-20: Incorrect fuzzy translation</b></div> <div id="fix"> The fuzzy translation at line 17144 says 'Se a linha de tendência deve ser exibida' (trend line), but the msgid refers to a numbered column feature. Users will misunderstand what this setting controls. (See also: [CWE-20](https://cwe.mitre.org/data/definitions/20.html)) </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/pt_BR/LC_MESSAGES/messages.po +++ b/superset/translations/pt_BR/LC_MESSAGES/messages.po @@ -17139,7 +17139,7 @@ msgstr "Se devem ser exibidos os valores mínimo e máximo do eixo Y" #, fuzzy msgid "Whether to display the numbered column" -msgstr "Se a linha de tendência deve ser exibida" +msgstr "Se a coluna numerada deve ser exibida" ``` </div> </details> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -4367,6 +4371,13 @@ msgstr "Niestandardowy SQL" msgid "Custom SQL ad-hoc metrics are not enabled for this dataset" msgstr "Niestandardowe metryki SQL ad-hoc nie są włączone dla tego zestawu danych" +msgid "Custom SQL fields cannot be parsed as a single SQL statement." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty translation for new string</b></div> <div id="fix"> The msgstr is empty, so Polish users will see the untranslated English text. Provide an accurate Polish translation. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -1266,6 +1266,10 @@ msgstr "Dodaj nowy formater kolorów" msgid "Add new formatter" msgstr "Dodaj nowy formater" +#, fuzzy +msgid "Add numbered column" +msgstr " aby dodać obliczane kolumny" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect translation for new string</b></div> <div id="fix"> The translation ' aby dodać obliczane kolumny' ('to add calculated columns') does not match the msgid 'Add numbered column'. The leading space and incorrect meaning will confuse users. Provide a direct translation like 'Dodaj ponumerowaną kolumnę'. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -4367,6 +4371,13 @@ msgstr "Niestandardowy SQL" msgid "Custom SQL ad-hoc metrics are not enabled for this dataset" msgstr "Niestandardowe metryki SQL ad-hoc nie są włączone dla tego zestawu danych" +msgid "Custom SQL fields cannot be parsed as a single SQL statement." +msgstr "" + +#, fuzzy +msgid "Custom SQL fields cannot contain set operations." +msgstr "Pola niestandardowego SQL nie mogą zawierać podzapytań." Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect translation - wrong SQL concept</b></div> <div id="fix"> The translation says 'sub-queries' but the msgid specifies 'set operations'. These are different SQL concepts (UNION, INTERSECT, EXCEPT vs nested SELECT). Users may be misled about what operations are restricted. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -9825,6 +9836,10 @@ msgstr "Nie zdefiniowano" msgid "Not equal to (≠)" msgstr "Nie równe (≠)" +#, fuzzy +msgid "Not found" +msgstr "Nie znaleziono wykresu" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Overly specific translation</b></div> <div id="fix"> The translation 'Nie znaleziono wykresu' specifically says 'Chart not found', but the msgid is the generic 'Not found'. This translation is too specific and may mislead users in non-chart contexts. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -10931,6 +10946,12 @@ msgstr "Przestarzałe" msgid "Proportional" msgstr "Proporcjonalny" +msgid "Public and privately shared sheets" +msgstr "" + +msgid "Publicly shared sheets only" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing translations for new strings</b></div> <div id="fix"> New strings added with empty translations. These are Google Sheets permission options that need Polish translations for the UI to display correctly in Polish locale. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -5913,7 +5924,7 @@ msgid "Duration in ms (100.40008 => 100ms 400µs 80ns)" msgstr "Czas trwania w ms (100.40008 => 100ms 400µs 80ns)" #, fuzzy -msgid "Duration in ms (10500 => 0:10.5)" +msgid "Duration in ms (10500 => 0:00:10.5)" msgstr "Czas trwania w ms (66000 => 1m 6s)" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Inconsistent format example in translation</b></div> <div id="fix"> The translation example shows '1m 6s' but the msgid now shows '0:00:10.5' (HH:MM:SS.s format). The format example is inconsistent with the English text. </div> </div> <small><i>Code Review Run #a31485</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
