jesperct opened a new pull request, #40805:
URL: https://github.com/apache/superset/pull/40805
### SUMMARY
The toast notification container (`ToastPresenter`) is a `position: fixed`
element that spans most of the viewport height (`height: calc(100vh - 100px)`)
at a high z-index. A plain `div` captures pointer events across its entire box,
so even when only one toast is visible at the bottom, the container's empty
area sat on top of any controls in the same vertical strip and swallowed their
clicks. In practice this blocked the dashboard header's **Save** / **Edit
dashboard** buttons while a toast was on screen, until the toast timed out or
was dismissed.
The fix sets `pointer-events: none` on the container and re-enables
`pointer-events: auto` on each `.toast`. Clicks now fall through the empty area
to the controls underneath, while individual toasts stay fully interactive
(close button, content scrolling).
### BEFORE/AFTER
**Before:** While a toast is visible in a bottom corner, buttons in the same
vertical strip (e.g. the dashboard Save / Edit buttons) cannot be clicked.
Interaction only resumes once the toast disappears.
**After:** The empty area of the toast container passes clicks through, so
those buttons respond immediately while toasts are still showing. Toasts
themselves remain clickable and dismissable.
### TESTING INSTRUCTIONS
1. Open a dashboard.
2. Trigger a toast near a corner (for example, save the dashboard, or any
action that shows a success/info toast).
3. While the toast is still visible, click a button in the same vertical
strip as the toast container (e.g. **Edit dashboard** / **Save** in the header).
- Before this change: the click is swallowed until the toast disappears.
- After this change: the button responds immediately.
Unit tests in `ToastPresenter.test.tsx` assert the container renders with
`pointer-events: none` and each toast with `pointer-events: auto`.
### ADDITIONAL INFORMATION
- [x] Changes UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
