jesperct commented on PR #40730: URL: https://github.com/apache/superset/pull/40730#issuecomment-4632667427
Added the post-mount test you suggested, @EnxDev: it renames the dashboard after the page has mounted and checks that document.title follows the live title. I confirmed it actually guards the behavior by emptying the effect's dependency array so it only runs on mount, which made the new test fail while the initial-render tests kept passing. I also fixed a related issue the automated reviewers flagged: during navigation between dashboards the reused Redux layout kept the previous dashboard's title until the new one hydrated. The live title is now used only when the hydrated dashboard id matches the one being shown, and falls back to the API title otherwise. Added a test for that case too. Commits 7bdb240 and c2843f1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
