bito-code-review[bot] commented on code in PR #40695:
URL: https://github.com/apache/superset/pull/40695#discussion_r3364271577
##########
superset/security/manager.py:
##########
@@ -633,6 +633,12 @@ def create_login_manager(self, app: Flask) -> LoginManager:
return lm
def on_user_login(self, user: Any) -> None:
+ # pylint: disable=import-outside-toplevel
+ from superset.security.session_invalidation import stamp_login_time
+
+ # Record the authentication time so outstanding sessions can be
+ # invalidated when the account is later disabled.
+ stamp_login_time()
Review Comment:
<!-- Bito Reply -->
The update to the test case is appropriate. By adding the mock for
`stamp_login_time` and asserting it is called once, the test now correctly
verifies that the session stamping logic is executed during the user login
process, addressing the previously identified coverage gap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
