rusackas commented on PR #38792: URL: https://github.com/apache/superset/pull/38792#issuecomment-4635399134
Thanks @jaymasiwal! The `Select.tsx` change itself looks like the right direction. Two things before this can go in: The big one: this PR deletes ~2,500 lines of tests — `SelectControl` (474→189), `CustomFrame` (342→204), and most of `DatasetList.listview` — and a lot of that (delete/bulk/permission/error-path tests) has nothing to do with dropdowns. The portal change means some selectors need updating to `screen`/`within(document.body)`, but let's update them rather than remove the cases. Could you restore those and keep this scoped to the actual fix? Smaller: `AsyncSelect.tsx` still has the old `parentNode` default — should it get the same treatment so the two stay consistent? And the modal selector elsewhere in the codebase is `.ant-modal-content` rather than `.ant-modal`. Then a rebase (heads up: `DatasetList.listview.test.tsx` will conflict — master's version is the one to keep). Happy to re-review once it's slimmed down -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
