aminghadersohi commented on PR #40771: URL: https://github.com/apache/superset/pull/40771#issuecomment-4636222142
@rusackas good catch — the `native_filters` addition is indeed outside the intended scope, but it was a required regression fix rather than intentional feature work. The allowlist enforcement we added means any column absent from `all_columns` is silently dropped from `select_columns`; `native_filters` was missing from `DASHBOARD_EXTRA_COLUMNS` so `get_all_column_names(get_dashboard_columns())` excluded it, and the existing `test_list_dashboards_sanitizes_dashboard_descriptions_and_filter_text` broke when it tried to select it. Adding it restores the pre-existing behaviour rather than introducing new capability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
