rusackas opened a new pull request, #40818:
URL: https://github.com/apache/superset/pull/40818

   ### SUMMARY
   
   This is a **test-only PR** opened as a TDD-style validation of issue #29519.
   
   #29519 reports that a dashboard-level filter that is in scope for a 
**Mixed** (`mixed_timeseries`) chart applies to **Query A** but sometimes not 
to **Query B**.
   
   A Mixed chart issues a single query context containing two queries 
(`queries[0]` = A, `queries[1]` = B). This PR adds a Playwright spec that 
creates a Mixed chart, places it on a dashboard behind a native filter scoped 
to the chart, loads the dashboard, and inspects the outgoing `POST 
/api/v1/chart/data` payload to assert the filter appears in **both** queries.
   
   1. **`Mixed chart applies dashboard filter to both queries (#29519)`** — 
asserts `queries[0].filters` and `queries[1].filters` both contain the in-scope 
dashboard filter.
   
   **Status:** on current `master` this test **passes** — both queries inherit 
the dashboard filter — which indicates the reported behavior is resolved at the 
query-building level (`buildQuery` propagates `extra_form_data` to both 
queries). This PR therefore validates the fix and locks in a regression guard; 
merging closes #29519.
   
   ### How to interpret CI
   
   - **CI green** → both queries inherit the dashboard filter (contract holds); 
merging closes #29519 and guards against regressions.
   - **CI red** → Query B dropped the filter; the bug is live in the Mixed 
chart query path 
(`superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries`).
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   cd superset-frontend
   npx playwright test 
playwright/tests/dashboard/mixed-chart-dashboard-filters.spec.ts
   ```
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: closes #29519
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to