bito-code-review[bot] commented on code in PR #40746:
URL: https://github.com/apache/superset/pull/40746#discussion_r3366279630
##########
superset/mcp_service/user/schemas.py:
##########
@@ -104,6 +104,26 @@ class UserInfo(BaseModel):
"access via get_user_info; not available in list_users because roles "
"is a relationship, not a selectable column)",
)
+
+ @field_validator("roles", mode="before")
+ @classmethod
+ def _extract_role_names(cls, v: Any) -> list[str] | None:
+ """Coerce Role ORM objects to their .name strings."""
+ if v is None:
+ return None
+ if isinstance(v, str):
+ # Preserve Pydantic's default rejection of bare strings for
list[str].
+ raise ValueError("roles must be a list, not a string")
+ result: list[str] = []
+ for item in v:
+ if isinstance(item, str):
+ result.append(item)
+ elif hasattr(item, "name"):
+ try:
+ result.append(str(item.name))
+ except DetachedInstanceError:
+ continue
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Duplicate role extraction logic</b></div>
<div id="fix">
The `_extract_role_names` validator duplicates the role-extraction logic
already implemented in `serialize_user_object` (lines 298-303). This creates
maintenance risk: if the extraction logic changes (e.g., adding error handling
for edge cases), both locations must be updated in sync. Consider having the
validator only handle type coercion (None/string validation) and let
`serialize_user_object` remain the single source of truth for ORM-to-string
conversion.
</div>
</div>
<small><i>Code Review Run #22db82</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
