rusackas opened a new pull request, #40854:
URL: https://github.com/apache/superset/pull/40854

   ### SUMMARY
   
   Follow-up to #38108, which added social media badges to the website footer.
   The badges use each brand's **native fill** — Slack `#4A154B` (dark 
aubergine),
   X `#484848` (near-black), LinkedIn/Bluesky blue, Reddit orange. Against the 
dark
   footer background (`#173036`), **Slack is effectively invisible and X is very
   low-contrast**:
   
   | icon | fill | on `#173036` footer |
   |---|---|---|
   | slack | `#4A154B` | ❌ nearly invisible |
   | x | `#484848` | ⚠️ low contrast |
   | linkedin / bluesky / reddit | blue / blue / orange | ok |
   
   All five are single-path SVG glyphs whose interior details (the LinkedIn 
"in",
   the Slack gaps, the Reddit face) are **transparent cut-outs**, so a one-line
   CSS filter renders them as clean, uniform **white** logos that stay legible —
   the cut-outs simply show the dark footer through them. This avoids shipping
   five separate recolored white SVGs and keeps the brand-colored source assets
   intact for any other use.
   
   ```css
   .footer__social-links img {
     ...
     filter: brightness(0) invert(1);
   }
   ```
   
   ### BEFORE/AFTER
   
   Before: Slack mark blends into the footer (barely visible). After: all five
   icons render as consistent white silhouettes.
   
   ### TESTING INSTRUCTIONS
   
   Build the docs (`cd docs && yarn build && yarn serve`) and check the footer —
   all five social icons render white and legible on the dark background.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to