rusackas opened a new pull request, #40855: URL: https://github.com/apache/superset/pull/40855
### SUMMARY `ExtraCache.url_param()` reads a parameter from either the request query string (`request.args`) or from `form_data['url_params']`. The two sources were not handled consistently: when the value came from `request.args` the function returned it through an early `return`, **skipping** the dialect-specific quoting and the cache-key wrapping that the `form_data` path applies a few lines below. This change funnels both input sources through the same tail so the result is processed identically regardless of where the parameter originated: - the `request.args` and `form_data` branches now only *select* the raw value; - the existing `escape_result`/dialect quoting and `add_to_cache_keys` handling then runs once for both. No change for the `form_data` path. For the query-string path the value is now quoted via the same dialect logic (and included in the cache key) instead of being returned verbatim. `escape_result=False` still returns the raw value, matching the documented behavior. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — backend behavior consistency. ### TESTING INSTRUCTIONS ``` pytest tests/unit_tests/jinja_context_test.py -k url_param ``` New tests assert the query-string path is quoted the same way as the `form_data` path, and that `escape_result=False` returns the raw value. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
