rusackas opened a new pull request, #40858:
URL: https://github.com/apache/superset/pull/40858

   ### SUMMARY
   
   The `get_filters` docstring in `superset/jinja_context.py` included a usage 
example that built a `LIKE` clause by hand-escaping the filter value with 
`replace("'", "''")`. Hand-rolled escaping like that is incomplete and easy to 
get wrong, and the docstring is a pattern users copy.
   
   This updates the documentation only:
   - removes the hand-escaped `LIKE` branch from the example;
   - keeps the `where_in`-based `IN` example (the recommended approach);
   - adds a `.. warning::` advising against hand-escaping filter values into 
SQL and pointing to `where_in` / the `IN` operator.
   
   No code behavior changes.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — docstring only.
   
   ### TESTING INSTRUCTIONS
   
   ```
   pytest tests/unit_tests/jinja_context_test.py -k get_filters
   ```
   
   (`get_filters` behavior is unchanged; existing tests pass.)
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to