bito-code-review[bot] commented on PR #40861: URL: https://github.com/apache/superset/pull/40861#issuecomment-4651518230
<!-- Bito Reply --> The flagged issue is correct: the error message change in `superset/mcp_service/auth.py` breaks existing tests that expect the old message. However, the PR diff shows that the developer has already updated several tests in `tests/unit_tests/mcp_service/test_auth_api_key.py` to match the new error message. It appears the test mentioned in the comment, `tests/unit_tests/mcp_service/test_auth_user_resolution.py::test_raises_when_no_auth_source`, was simply missed during the update. To resolve this, update the assertion in `tests/unit_tests/mcp_service/test_auth_user_resolution.py` to match the new error string. **tests/unit_tests/mcp_service/test_auth_user_resolution.py** ``` - with pytest.raises(ValueError, match="No authenticated user found") + with pytest.raises(ValueError, match="Authentication required") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
