Copilot commented on code in PR #40862:
URL: https://github.com/apache/superset/pull/40862#discussion_r3375249026
##########
helm/superset/README.md:
##########
@@ -110,7 +110,7 @@ On helm this can be set on
`extraSecretEnv.SUPERSET_SECRET_KEY` or `configOverri
| init.priorityClassName | string | `nil` | Set priorityClassName for init job
pods |
| init.resources | object | `{}` | |
| init.tolerations | list | `[]` | |
-| init.topologySpreadConstraints | list | `[]` | TopologySpreadConstrains to
be added to init job |
+| init.topologySpreadConstraints | list | `[]` | TopologySpreadConstraints to
be added to init job |
Review Comment:
This README is generated by helm-docs from helm/superset/values.yaml (see
values.yaml header comment). The source comments in values.yaml still use the
old typo “TopologySpreadConstrains”, so the next helm-docs run will overwrite
this corrected text. Apply the same wording fix in values.yaml and re-run
helm-docs to keep generated docs stable.
##########
helm/superset/README.md:
##########
@@ -122,7 +122,7 @@ On helm this can be set on
`extraSecretEnv.SUPERSET_SECRET_KEY` or `configOverri
| resources | object | `{}` | |
| runAsUser | int | `0` | User ID directive. This user must have enough
permissions to run the bootstrap script Running containers as root is not
recommended in production. Change this to another UID - e.g. 1000 to be more
secure |
| secretEnv | object | `{"create":true}` | Specify rather or not helm should
create the secret described in `secret-env.yaml` template |
-| secretEnv.create | bool | `true` | Change to false in order to support
externally created secret (Binami "Sealed Secrets" for Kubernetes or External
Secrets Operator) note: when externally creating the secret, the chart still
expects to pull values from a secret with the name of the release defaults to
`release-name-superset-env` - full logic located in _helpers.tpl file: `define
"superset.fullname"` |
+| secretEnv.create | bool | `true` | Change to false in order to support
externally created secret (Bitnami "Sealed Secrets" for Kubernetes or External
Secrets Operator) note: when externally creating the secret, the chart still
expects to pull values from a secret with the name of the release defaults to
`release-name-superset-env` - full logic located in _helpers.tpl file: `define
"superset.fullname"` |
Review Comment:
This README is generated by helm-docs from helm/superset/values.yaml. The
values.yaml source comment still says “Binami” (typo), so this “Bitnami”
correction will be reverted on the next regeneration. Update the values.yaml
comment and regenerate the README to avoid drift.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
