rusackas commented on PR #39369:
URL: https://github.com/apache/superset/pull/39369#issuecomment-4654922867
Rebased this onto latest `master` and reconciled the lockfile (regenerated
against the recent jest/ag-grid churn on main, so it's clean now).
I verified the v2 migration end to end:
- **Only usage** of `simple-zstd` in the repo is
`superset-frontend/webpack.proxy-config.js` (dev-server proxy, decoding
`zstd`-encoded HTML responses from the backend). It's dev/build tooling only —
not shipped runtime code.
- **v2 breaking changes** (from the upstream changelog): the API was
redesigned to be promise-based and modernized to native Node tooling. v1's
synchronous `ZSTDDecompress()` is gone; v2 exports `decompress(opts?) =>
Promise<Duplex>`. Engine requirement is Node >=22, which we already require
(`engines.node: ^22.22.0`), so no conflict there.
- The adaptation here is correct: import `{ decompress: zstdDecompress }`,
`await zstdDecompress()`, and `processHTML` is now `async` with a `.catch()` at
the call site so proxy errors surface instead of hanging the response.
- I exercised the actual code path with a round-trip test (`compress` → pipe
through `await decompress()` → collect body) against system zstd 1.5.7 —
byte-for-byte match.
prettier and oxlint pass on the touched file. This is landable from my side;
deferring the merge to normal CI/review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
