rusackas opened a new pull request, #40882:
URL: https://github.com/apache/superset/pull/40882

   ### SUMMARY
   
   Follow-up to #40880. Repoints CI's `services:` containers — `postgres`, 
`redis`, `mysql`, `presto` — across the **E2E**, **Python-Integration**, and 
**Presto/Hive** workflows at the GHCR mirror (`ghcr.io/apache/superset/ci/*`) 
and **removes the `credentials:` blocks**.
   
   Public GHCR images pull **without** Docker Hub's anonymous rate limit **and 
without any credentials**, so this:
   - kills the service-pull flakes on `master` / same-repo PRs (the problem 
#40875 tried to solve), **and**
   - keeps **fork PRs working** — unlike `credentials:` on the service blocks, 
where a fork's empty secrets resolve to `''` and fail the workflow at parse 
time (`Unexpected value ''`). See #40880 for the full root-cause writeup.
   
   Net diff: every `image:` flips to its `ghcr.io/apache/superset/ci/...` 
mirror, each DOCKERHUB `credentials:` block is deleted, and the now-incorrect 
"falls back to anonymous" comments are removed.
   
   ### 🚫 DO NOT MERGE until the GHCR mirror is live
   
   This is a **draft** and intentionally gated on #40880:
   
   1. Merge #40880 (the mirror workflow).
   2. Run "Mirror service images to GHCR" once and **confirm 
`ghcr.io/apache/superset/*` push works** under ASF infra.
   3. Set the four mirrored packages (`ci/postgres`, `ci/redis`, `ci/mysql`, 
`ci/presto`) to **public**.
   4. Rebase this PR on `master` and mark ready. (If the #40875 revert #40879 
lands first, the credentials-removal hunks simply no-op on rebase, leaving only 
the image repoint.)
   
   Until the packages exist and are public, **this PR's own CI will be red** 
(it'll try to pull images that aren't there yet) — that's expected.
   
   ### Out of scope
   
   The `bde2020/hive-metastore-postgresql` image is pulled via `docker compose` 
(not a `services:` block) and is unaffected by this change — a separate, 
optional follow-up if we want it mirrored too.
   
   ### TESTING INSTRUCTIONS
   
   Once the mirror is public and this is rebased, the existing 
integration/E2E/Presto-Hive suites exercise the pulls. Fork-PR behavior is the 
key check: a fork PR's jobs should reach the test phase instead of failing at 
"Set up job".
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to