rusackas commented on PR #40660: URL: https://github.com/apache/superset/pull/40660#issuecomment-4661870624
@rebenitez1802 Thanks for the review! Rather than deferring it, I went ahead and added the regression test in this PR — `test_dashboard_permalink_native_filters_encoded` in `tests/integration_tests/core_tests.py` verifies a `native_filters` value with reserved characters (`&`, `=`, `#`) is percent-encoded in the redirect `Location` header and cannot inject extra query params. So the coverage is in place here, no follow-up needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
