rusackas commented on code in PR #40650:
URL: https://github.com/apache/superset/pull/40650#discussion_r3382325466
##########
superset/commands/security/create.py:
##########
@@ -50,5 +51,8 @@ def validate(self) -> None:
)
if len(tables) != len(self._tables):
raise DatasourceNotFoundValidationError()
+ for table in tables:
+ if not security_manager.can_access_datasource(datasource=table):
+ raise RLSDatasourceForbiddenError()
Review Comment:
Went ahead and did this in-PR after all: extracted the duplicated datasource
access-check loop into a shared `raise_for_datasource_access` helper in
`superset/commands/security/utils.py`, now used by the create, update, and
delete RLS rule commands. Thanks for the nudge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
