rusackas commented on PR #34592: URL: https://github.com/apache/superset/pull/34592#issuecomment-4661950348
Thanks @rafal-celinski, this remains a much-wanted fix. Two things before it can land: if you could please rebase (branch is still conflicting), and let's find a way to reach consensus on the multi-query approach I raised (see Discussion #29297 and how AG Grid handles non-additive totals), since firing a query per groupby combination has performance trade-offs. Once we're aligned we'll get it reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
