rusackas commented on PR #34407: URL: https://github.com/apache/superset/pull/34407#issuecomment-4661965390
Thank you for this, @rsbhatti! 🙏 I've adopted it in #40908 (on the origin repo) with you credited as co-author. It keeps your approach and adds a few merge-readiness cleanups — retains the existing `FAB_API_SWAGGER_UI` flag, drops an unrelated `AUTH_ROLE_PUBLIC` edit, adds ASF headers + type hints + a unit test, and fixes the `Supserset` class-name typo. Closing this in favor of #40908; the fix for #33304 lives on there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
