rusackas commented on PR #40863: URL: https://github.com/apache/superset/pull/40863#issuecomment-4662288026
Closing as superseded by #40636 (merged), which landed the same query-amplification bounds — `VIZ_TIME_COMPARE_MAX` / `DECK_MULTI_MAX_SLICES` in config.py, the matching bounds in `viz.py` for time_compare (`run_extra_queries`) and deck_slices (`DeckGLMultiLayer.get_data`), plus equivalent unit tests. Rebasing this branch onto master collapses it to a near-empty diff. #40636 also addresses @Vitor-Avila's review point about a too-low default — it shipped a more generous `50` (vs the `10` here) with clearer count-bearing error messages. If the small non-list `deck_slices` guard is worth keeping, I'll file it as a trivial standalone follow-up. Thanks @Vitor-Avila for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
