sadpandajoe opened a new pull request, #40913:
URL: https://github.com/apache/superset/pull/40913
### SUMMARY
Ports the deprecated Cypress dashboard spec `_skip.url_params.test.ts`
(removed in #40384) to a Jest integration test with a mocked network.
The request-construction contract — that `form_data.url_params` is
forwarded onto every query in the `/api/v1/chart/data` request body —
is verifiable without a backend. The new test drives
`getChartDataRequest` through the real
`buildV1ChartDataPayload` → `buildQueryContext` → `buildQueryObject`
path (no stubs) and asserts the intercepted POST body's
`queries[].url_params` and `form_data.url_params`. A third case pins
the existing default of `{}` when `url_params` is absent, so a future
change to that default fails loudly rather than silently changing the
wire shape.
The URL-string → `form_data.url_params` hop (handled by `extractUrlParams`
in `src/dashboard/actions/hydrate.ts`) is intentionally out of scope here
and is covered by its own unit tests.
Part of the Cypress → Jest/Playwright migration.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — test-only change.
### TESTING INSTRUCTIONS
From \`superset-frontend/\`:
\`\`\`bash
npm run test -- src/components/Chart/urlParamsForwarding.integration.test.ts
\`\`\`
Expected: 3 tests pass.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
