bito-code-review[bot] commented on PR #40915:
URL: https://github.com/apache/superset/pull/40915#issuecomment-4663292125
<!-- Bito Reply -->
The flagged issue is correct. Using `if (!userId) return;` treats a `userId`
of `0` as falsy, causing the initialization logic to be skipped for users with
that ID. To resolve this, you should use an explicit check for `null` or
`undefined`.
Here is the corrected implementation for
`superset-frontend/src/extensions/ExtensionsStartup.tsx`:
```tsx
useEffect(() => {
if (userId === null || userId === undefined) return;
// Provide the implementations for @apache-superset/core
```
I have checked the available PR comments and diffs, and there are no other
pending review comments to address. Would you like me to perform any other
analysis on this PR?
**superset-frontend/src/extensions/ExtensionsStartup.tsx**
```
useEffect(() => {
if (userId === null || userId === undefined) return;
// Provide the implementations for @apache-superset/core
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
