aminghadersohi commented on code in PR #40778:
URL: https://github.com/apache/superset/pull/40778#discussion_r3383430567
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx:
##########
@@ -960,3 +960,145 @@ test('empty state disappears when a filter is added via
dropdown', async () => {
});
expect(screen.getByText(FILTER_TYPE_REGEX)).toBeInTheDocument();
});
+
+test('restores a deleted filter via the "Restore filter" button', async () => {
+ const nativeFilterConfig = [
+ buildNativeFilter('NATIVE_FILTER-1', 'state', []),
+ buildNativeFilter('NATIVE_FILTER-2', 'country', []),
+ ];
+ const state = {
+ ...defaultState(),
+ dashboardInfo: {
+ metadata: { native_filter_configuration: nativeFilterConfig },
+ },
+ dashboardLayout,
+ };
+
+ defaultRender(state, { ...props, createNewOnOpen: false });
+
+ const filterContainer = screen.getByTestId('filter-title-container');
+ const firstTab = within(filterContainer).getAllByRole('tab')[0];
+ const deleteIcon = firstTab.querySelector('[data-icon="delete"]');
Review Comment:
`data-icon="delete"` is an internal Ant Design SVG attribute — not a public
API — and can silently break on an antd upgrade. Prefer `getByRole("button", {
name: /delete/i })` if the icon button has an accessible label, or add a
`data-testid` to the delete trigger in the component.
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx:
##########
@@ -960,3 +960,145 @@ test('empty state disappears when a filter is added via
dropdown', async () => {
});
expect(screen.getByText(FILTER_TYPE_REGEX)).toBeInTheDocument();
});
+
+test('restores a deleted filter via the "Restore filter" button', async () => {
+ const nativeFilterConfig = [
+ buildNativeFilter('NATIVE_FILTER-1', 'state', []),
+ buildNativeFilter('NATIVE_FILTER-2', 'country', []),
+ ];
+ const state = {
+ ...defaultState(),
+ dashboardInfo: {
+ metadata: { native_filter_configuration: nativeFilterConfig },
+ },
+ dashboardLayout,
+ };
+
+ defaultRender(state, { ...props, createNewOnOpen: false });
+
+ const filterContainer = screen.getByTestId('filter-title-container');
+ const firstTab = within(filterContainer).getAllByRole('tab')[0];
+ const deleteIcon = firstTab.querySelector('[data-icon="delete"]');
+ fireEvent.click(deleteIcon!);
+
+ expect(
+ await screen.findByText(/you have removed this filter/i),
+ ).toBeInTheDocument();
+ const restoreButton = screen.getByTestId('restore-filter-button');
+ await userEvent.click(restoreButton);
+
+ await waitFor(() => {
+ expect(
+ screen.queryByText(/you have removed this filter/i),
+ ).not.toBeInTheDocument();
+ });
+ expect(screen.getByRole('textbox', { name: FILTER_NAME_REGEX })).toHaveValue(
+ 'state',
+ );
+}, 30000);
+
+test('undoes a filter deletion via the sidebar "Undo?" link', async () => {
+ const nativeFilterConfig = [
+ buildNativeFilter('NATIVE_FILTER-1', 'state', []),
+ buildNativeFilter('NATIVE_FILTER-2', 'country', []),
+ ];
+ const state = {
+ ...defaultState(),
+ dashboardInfo: {
+ metadata: { native_filter_configuration: nativeFilterConfig },
+ },
+ dashboardLayout,
+ };
+
+ defaultRender(state, { ...props, createNewOnOpen: false });
+
+ const filterContainer = screen.getByTestId('filter-title-container');
+ const firstTab = within(filterContainer).getAllByRole('tab')[0];
+ fireEvent.click(firstTab.querySelector('[data-icon="delete"]')!);
Review Comment:
Same `[data-icon="delete"]` selector concern as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
