gkneighb commented on PR #40399: URL: https://github.com/apache/superset/pull/40399#issuecomment-4663469525
Thanks for the approval @aminghadersohi! Quick follow-up on the NIT: - `generate_dashboard.py` — already had the URL extracted to a local `dashboard_url` (line 431-433) from an earlier round, so nothing more to do there. - `update_dashboard.py` — the same pattern was repeated in two return sites; extracted to a module-level `_build_dashboard_url(dashboard)` helper in c6293ff. Both call sites now read as `dashboard_url=_build_dashboard_url(dashboard)`. Net +10 / −8. Ready to merge whenever you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
