rusackas commented on code in PR #40673:
URL: https://github.com/apache/superset/pull/40673#discussion_r3383918164
##########
superset/databases/api.py:
##########
@@ -568,7 +573,11 @@ def put(self, pk: int) -> Response:
exc_info=True,
)
return self.response_422(message=str(ex))
- except (SSHTunnelingNotEnabledError, SSHTunnelDatabasePortError) as ex:
+ except (
+ SSHTunnelingNotEnabledError,
+ SSHTunnelDatabasePortError,
+ SSHTunnelHostKeyVerificationError,
+ ) as ex:
Review Comment:
Correct — UpdateDatabaseCommand does not invoke
TestConnectionDatabaseCommand and performs no SSH host-key verification, so
SSHTunnelHostKeyVerificationError can never propagate from the put() handler.
Removed it from that except block as dead code; the import stays in place for
the post() and test_connection() handlers, which do hit the verification path.
Pushed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
