bito-code-review[bot] commented on PR #40906:
URL: https://github.com/apache/superset/pull/40906#issuecomment-4665159928
<!-- Bito Reply -->
The concern regarding the `query: str | None` schema is valid. Because
`fastmcp` (and the underlying Pydantic-based schema generation) renders `str |
None` as an `anyOf` structure, it can cause compatibility issues with certain
MCP clients that expect a concrete, top-level type. Flattening this to a plain
`{"type": "string"}` is a recommended approach to ensure compatibility with the
bridges, similar to how `call_tool` arguments are handled. Additionally,
updating `test_search_tool_query_is_optional_in_schema` to assert that the
`query` field has a concrete type would provide a necessary safeguard against
this regression.
**superset/mcp_service/server.py**
```
query: Annotated[
str,
"Natural language query. Omit to list all available tools.",
] = None,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
