bito-code-review[bot] commented on PR #40929:
URL: https://github.com/apache/superset/pull/40929#issuecomment-4668025035
<!-- Bito Reply -->
The flagged issue is correct. In
`superset-frontend/src/dashboard/containers/DashboardPage.tsx`, the current
implementation assigns `isOldRison` directly to `dataMask` in the `else` branch
if it is not an object, which can lead to an invalid state shape if
`getUrlParam` returns a raw string due to a Rison decoding failure.
To resolve this, you should guard the assignment to ensure `dataMask`
remains an object map. You can update the `else` block to default to an empty
object `{}` when `isOldRison` is not a valid object:
```typescript
} else {
dataMask = {};
}
```
I have checked the PR comments and there are no other review comments to
address. Would you like me to implement this fix for you?
**superset-frontend/src/dashboard/containers/DashboardPage.tsx**
```
} else {
dataMask = {};
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
