durgaprasadml opened a new pull request, #40935:
URL: https://github.com/apache/superset/pull/40935
Summary
This PR improves MCP parity with the Explore UI by enhancing support for
adhoc SQL metrics and virtual dataset authoring workflows.
Changes Included
Virtual Dataset Enhancements
* Added support for:
* metrics
* calculated_columns
in CreateVirtualDatasetRequest
* Updated create_virtual_dataset flow to persist metrics and calculated
columns using UpdateDatasetCommand
* Added handling for dataset update failures
* Added unit test coverage for metric and calculated column persistence
Chart Authoring Improvements
* Improved MCP chart-authoring guidance and examples for adhoc SQL metrics
using sql_expression
* Added examples for:
* ratio metrics
* weighted averages
* conditional aggregates
* Updated chart schema example payloads to demonstrate valid adhoc SQL
metric configurations
Notes
Backend support for adhoc SQL metrics already existed through existing
metric validation and form_data handling paths.
This PR focuses on:
* improving MCP discoverability
* enabling end-to-end MCP authoring workflows
* improving LLM guidance/schema examples
* bringing MCP virtual dataset creation closer to Explore UI parity
The implementation preserves backward compatibility and reuses existing
Explore-side metric handling mechanisms.
Testing
Added unit tests for:
* virtual dataset metric persistence
* calculated column persistence
* dataset update invocation flow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
