rusackas commented on PR #24380:
URL: https://github.com/apache/superset/pull/24380#issuecomment-4672477539
I pushed a rebased revision that addresses the earlier review feedback and
brings this up to date with current `master`.
**Addressing @kgabryje's comments:**
- The control is now a `CheckboxControl` ("Y-axis range slider") next to the
existing `zoomable` ("Data Zoom") control, instead of a Yes/No `SelectControl`.
- The `dataZoom` logic moved into `transformProps.ts`; `EchartsBoxPlot.tsx`
is no longer touched (the previous version hand-wrote `dataZoom` inside the
component with invalid `'0rem'`/`'20rem'` values).
**Brought up to date with `master`:**
Since this PR was opened, `master` gained a generic `zoomable` control
(toolbox zoom + scroll-zoom). The new Y-axis slider is now **merged into** that
existing `dataZoom` array rather than overwriting it, so both features coexist.
The slider uses `filterMode: 'none'`, so it zooms the visible Y-axis window
without dropping outlier/box data outside the selected range — which matches
the original ask in #16745 (comparing box plots on the same meaningful Y range).
**Tests:** added unit coverage in `transformProps.test.ts` for the slider
being present when enabled, absent when disabled, and coexisting with
`zoomable`.
History was rebased onto `master` into a single commit (original authorship
preserved via co-author trailer). Marking ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
